-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Still Work In Progress] Test/file list #67
Open
chaoen
wants to merge
29
commits into
inwinstack:dev
Choose a base branch
from
chaoen:test/fileList
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `angular-breadcrumb` because it doesn't support nested path. And I re-implement a new breadcrumb component. * Remove angular-breadcrumb from dependencies * Add layout/breadcrumb component * Add a method call to $bucket for update the bucket length
* Add file.css * Add file.html
When user clicked the bucket on bucket list, we will change the state whcih is the user selected. * Add `selectBucket` method to BucketController * Update the view of bucket component
When the user enter into `file` state, the FileController will set the path to $file service and get file list. For testing the UI flow, I add a fake API call to $file service. * Add `getFiles` method to $file service for fetch file list * Add `setPaths` method to $file service for set the API prefix * Add basic view for view the state of FileController
…ature/files-list-component
Add file controller properties to file.html for UI display. * import file styles in file module * bind properties
* paths.folders is Array * add `prefix` parameters to api call
Testing service when init Testing controller when init
Add method to breadcrumb for update the paths and update file module. This commit can display bucket and files, but not yet support display folder. * add `updateFilePath` to $breadcrumb * add necessary method call to file controller
Add when setPaths in service Edit when init controller
testing both resolve then get data reject
DONE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is depend on PR #62