This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Add missing jshint/istanbul dependencies. #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2016 08:32
…o undefined string
…t, jshint and jasmine
|
Awesome, thanks for the PR! This is an area we're actively working on, so I'm going to merge this in, but it will probably change soon as we move to eslint and actually get testing and coverage set up (I'm not sure it has ever worked for app-lib). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
When running the tests/jshint npm scripts I encountered some issues so I refactored the scripts section within package.json.
Not sure why we are calling out node directly as the libraries
jshint/jasmine-nodeboth have the appropriate shebang reference unless I am missing something here?