Skip to content

Commit

Permalink
feat(tab-bar): make box shadow independent of expand mode (#30117)
Browse files Browse the repository at this point in the history
Issue number: internal
---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->
When the tab bar's expand mode is 'full' on the ionic theme, it does not
have a box shadow to separate it from the rest of the page.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->
- The tab bar on the ionic theme now has a box shadow independently of
its expand mode.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->
  • Loading branch information
OS-pedrolourenco authored Jan 13, 2025
1 parent 8234064 commit b0c5555
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/src/components/tab-bar/tab-bar.ionic.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@

gap: globals.$ion-space-300;

box-shadow: #{globals.$ion-elevation-2};

// TODO(ROU-10853): replace this value with a layer token
z-index: 10;
}
Expand Down Expand Up @@ -54,8 +56,6 @@

width: fit-content;

box-shadow: #{globals.$ion-elevation-2};

contain: content;
}

Expand Down

0 comments on commit b0c5555

Please sign in to comment.