-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): generate event type with inline types #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
requested review from
christian-bromann,
alicewriteswrongs and
liamdebeasi
January 18, 2024 00:51
liamdebeasi
approved these changes
Jan 18, 2024
rwaskiewicz
approved these changes
Jan 18, 2024
jcfranco
referenced
this pull request
in Esri/calcite-design-system
Apr 5, 2024
….4 (#9037) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@stencil/angular-output-target](https://stenciljs.com/) ([source](https://togithub.com/ionic-team/stencil-ds-output-targets)) | [`0.8.3` -> `0.8.4`](https://renovatebot.com/diffs/npm/@stencil%2fangular-output-target/0.8.3/0.8.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@stencil%2fangular-output-target/0.8.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@stencil%2fangular-output-target/0.8.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@stencil%2fangular-output-target/0.8.3/0.8.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@stencil%2fangular-output-target/0.8.3/0.8.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ionic-team/stencil-ds-output-targets (@​stencil/angular-output-target)</summary> ### [`v0.8.4`](https://togithub.com/ionic-team/stencil-ds-output-targets/releases/tag/%40stencil/angular-output-target%400.8.4) [Compare Source](https://togithub.com/ionic-team/stencil-ds-output-targets/compare/a3588e905186a0e86e7f88418fd5b2f9531b55e0...@stencil/[email protected]) #### What's Changed - fix(angular): generate event type with inline types by [@​sean-perkins](https://togithub.com/sean-perkins) in [https://github.com/ionic-team/stencil-ds-output-targets/pull/412](https://togithub.com/ionic-team/stencil-ds-output-targets/pull/412) **Full Changelog**: https://github.com/ionic-team/stencil-ds-output-targets/compare/[@​stencil/angular-output-target](https://togithub.com/stencil/angular-output-target)[@​0](https://togithub.com/0).8.2...[@​stencil/angular-output-target](https://togithub.com/stencil/angular-output-target)[@​0](https://togithub.com/0).8.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Esri/calcite-design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally for affected output targetsnpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When adding a custom event with an inline type:
The generated event type is invalid:
There are two issues:
IIonItemOptions
.Expected output is:
Issue URL: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev-build:
0.0.1-dev.11705624885.1949250b