-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): add autocomment to triage labeled issues #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaskiewicz
requested review from
alicewriteswrongs,
tanner-reits and
liamdebeasi
January 25, 2024 13:28
rwaskiewicz
commented
Jan 25, 2024
Comment on lines
+31
to
+33
Thanks for the issue! | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The double newline is necessary here, as it allows ionitron to render this as:
Thanks for the issue!
This project is currently maintained for the purposes of supporting the Ionic Framework.
At this time, only new issues & pull requests that support the Ionic Framework will be prioritized.
For the latest updates regarding the maintenance status of this project, please see [this section of the project's README](https://github.com/ionic-team/stencil-ds-output-targets#maintenance-status)
Otherwise, with only one newline in the yaml, we'd see the first item and the second item scrunched together:
Thanks for the issue!
This project is currently maintained for the purposes of supporting the Ionic Framework.
At this time, only new issues & pull requests that support the Ionic Framework will be prioritized.
For the latest updates regarding the maintenance status of this project, please see [this section of the project's README](https://github.com/ionic-team/stencil-ds-output-targets#maintenance-status)
liamdebeasi
approved these changes
Jan 25, 2024
tanner-reits
approved these changes
Jan 25, 2024
configure ionitron to automatically label comment any issue that is labeled 'triage' with the repo's current maintenance status. the motivation here is to bring clarity/set expectations to the amount of work that is done in the repo on a day-to-day basis and what its current goals are. the workflow that ionitron will follow upon applying this patch is as follows: 1. a new issue is created 2. ionitron will add the 'triage' label to the issue 3. upon successful application of the triage label, the comment in this patch will be added to the issue this pr only adds comments to issues - it does not do the same for pull requests. at this time, ionitron does not have support for labeling with a filter on author (e.g. ionic employees, renovatebot). to avoid unneeded noise in the repo, we choose to only comment on issues for the time being.
Co-authored-by: Liam DeBeasi <[email protected]>
Co-authored-by: Liam DeBeasi <[email protected]>
rwaskiewicz
force-pushed
the
rwaskiewicz/ionitron-maintenance-rep
branch
from
January 29, 2024 13:03
e2804c5
to
be9917f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally for affected output targetsnpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When folks open new issues in the repo, they're unaware of the maintenance status. We would like to do a better job at making this clear.
Issue URL: N/A
What is the new behavior?
configure ionitron to automatically label comment any issue that is labeled 'triage' with the repo's current maintenance status. the motivation here is to bring clarity/set expectations to the amount of work that is done in the repo on a day-to-day basis and what its current goals are.
the workflow that ionitron will follow upon applying this patch is as follows:
this pr only adds comments to issues - it does not do the same for pull requests. at this time, ionitron does not have support for labeling with a filter on author (e.g. ionic employees, renovatebot). to avoid unneeded noise in the repo, we choose to only comment on issues for the time being.
Does this introduce a breaking change?
Other information
Testing is hard to do here before we land it. I've done things like spell checking and ensuring the YAML file is valid, but this is one of those things we have to land/iterate on. It's super similar to what we do for holiday triage on both of our teams, so the risk here (of iteration) should be pretty low