numpy version updated #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
requested changes
Jun 26, 2024
docs/source/releases.rst
Outdated
| @@ -101,7 +101,7 @@ If you were previously using https://github.com/ioos/qartod , see the *Migrating | |||
| * Split out :code:`threshold` parameters into explicit :code:`suspect` and :code:`fail` parameters (`#4 <https://github.com/ioos/ioos_qc/pull/4>`_) | |||
| * Bug fixes | |||
| * Remove support for python 2 | |||
| * Upgrade numpy to 1.14 | |||
| * Upgrade numpy to < 2.0.0 | |||
There was a problem hiding this comment.
You don't edit past release notes. That is still true for the 0.1.0 from Feb 2019.
docs/source/releases.rst
Outdated
| @@ -114,7 +114,7 @@ We recommend going test by test and comparing the documentation: `0.0.3 <https:/ | |||
|
|
|||
| Specific changes to be aware of include: | |||
|
|
|||
| * Removing support for python 2 and requiring :code:`numpy>=1.14`. | |||
| * Removing support for python 2 and requiring :code:`numpy<2`. | |||
requirements.txt
Outdated
| @@ -2,7 +2,7 @@ geographiclib | |||
| geojson | |||
| h5netcdf | |||
| jsonschema | |||
| numpy>=1.14 | |||
| numpy<2 | |||
There was a problem hiding this comment.
The minimum Python is still a requirement. We are adding an upper pin only.
Suggested change
| numpy<2 | |
| numpy>=1.14,<2 |
Sakshamgupta90
force-pushed
the
fixed/numpy
branch
from
3ca438a to
1ea76ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy version should be less than 2 until we can fix the breaking changes.