Add pubsub Maxmessagesize config #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millken
commented
Jan 25, 2024
| cfg.MaxMessageSize = size | ||
| return nil | ||
| } | ||
| } |
dustinxie
reviewed
Jan 25, 2024
| @@ -381,7 +391,7 @@ func NewHost(ctx context.Context, options ...Option) (*Host, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| ps, err := newPubSub(ctx, host, pubsub.WithBlacklist(blacklist)) | |||
| ps, err := newPubSub(ctx, host, pubsub.WithBlacklist(blacklist), pubsub.WithMaxMessageSize(cfg.MaxMessageSize)) | |||
There was a problem hiding this comment.
this is the change that fix the issue (> 1M byte block) last night?
There was a problem hiding this comment.
yes，after updating config, the 1000tps test passed
CoderZhi
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default in the original libp2p is
1M, but the default is12Mhere.