Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails for images and videos #231

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

Thumbnails for images and videos #231

wants to merge 3 commits into from

Conversation

dokterbob
Copy link
Member

@dokterbob dokterbob commented Sep 2, 2022

TODO

  • Factor out client library to nyats/client package
  • Rebase with master
  • Video support (single static image, for now)
  • Fix codeclimate issue ;)
  • Gather UX and performance feedback
  • Gather legal feedback vis-a-vis gateway

Known issues

DO NOT MERGE

We are still hashing out the legal aspects around this.

@dokterbob
Copy link
Member Author

Ref: ipfs/ipfs-companion#1095

@dokterbob dokterbob force-pushed the nyats branch 2 times, most recently from c7ea421 to 338b437 Compare September 7, 2022 17:07
@dokterbob dokterbob changed the title Thumbailer WIP Thumbnails for images and videos Sep 22, 2022
@dokterbob dokterbob marked this pull request as ready for review September 22, 2022 11:27
@dokterbob dokterbob requested review from femans and Szeket September 22, 2022 11:27
@dokterbob dokterbob changed the base branch from master to staging September 22, 2022 12:50
@dokterbob dokterbob force-pushed the nyats branch 2 times, most recently from 39eb7c0 to 659c604 Compare September 22, 2022 12:58
* Configuration for relevant variables.
* Separate thumbnail components wrapping v-img.
* Use dweb.link as default IPFS gateway and our own gateway for thumbnails.
* Auto scale thumbnails to container size.
* Failure indicator for unavailable thumbnails/images.
@Szeket
Copy link
Contributor

Szeket commented Sep 23, 2022

Works fine over 4G network :) I like infinitive scrolling.
NSFW for videos doesn't work yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants