generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 110
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: ipns protobuf namespace conflict (#794)
* fix: ipns protobuf namespace conflict * Prefer `go generate` to `Makefile` for code generation --------- Co-authored-by: Andrew Gillis <[email protected]>
- Loading branch information
1 parent
8b305a3
commit 3586985
Showing
6 changed files
with
293 additions
and
272 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// These commands work around namespace conflicts that occur when multiple | ||
// repositories depend on .proto files with generic filenames. Due to the way | ||
// protobuf registers files (e.g., foo.proto or pb/foo.proto), naming | ||
// collisions can occur when the same filename is used across different | ||
// packages. | ||
// | ||
// The only way to generate a *.pb.go file that includes the full package path | ||
// (e.g., github.com/org/repo/pb/foo.proto) is to place the .proto file in a | ||
// directory structure that mirrors its package path. | ||
// | ||
// References: | ||
// - https://protobuf.dev/reference/go/faq#namespace-conflict | ||
// - https://github.com/golang/protobuf/issues/1122#issuecomment-2045945265 | ||
// | ||
//go:generate mkdir -p github.com/ipfs/boxo/ipns/pb | ||
//go:generate ln -f record.proto github.com/ipfs/boxo/ipns/pb/ | ||
//go:generate protoc --go_out=. github.com/ipfs/boxo/ipns/pb/record.proto | ||
//go:generate mv -f github.com/ipfs/boxo/ipns/pb/record.pb.go . | ||
//go:generate rm -rf github.com | ||
package pb |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.