Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move providing responsabilities from bitswap to blockservice #534

Closed

blockservice: add session workaround to work with wrapped blockservices

4060154
Select commit
Loading
Failed to load commit list.
Closed

Move providing responsabilities from bitswap to blockservice #534

blockservice: add session workaround to work with wrapped blockservices
4060154
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 16, 2024 in 0s

65.45% (-0.20%) compared to d8d7675

View this Pull Request on Codecov

65.45% (-0.20%) compared to d8d7675

Details

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (d8d7675) 65.64% compared to head (4060154) 65.45%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           revert-bad-sessions-changes     #534      +/-   ##
===============================================================
- Coverage                        65.64%   65.45%   -0.20%     
===============================================================
  Files                              207      208       +1     
  Lines                            25564    25511      -53     
===============================================================
- Hits                             16781    16697      -84     
- Misses                            7310     7332      +22     
- Partials                          1473     1482       +9     
Files Coverage Δ
bitswap/bitswap.go 69.51% <ø> (+2.07%) ⬆️
bitswap/options.go 41.17% <ø> (-3.27%) ⬇️
bitswap/server/server.go 58.50% <100.00%> (-7.97%) ⬇️
blockservice/providing_blockstore.go 14.28% <14.28%> (ø)
blockservice/blockservice.go 74.41% <55.00%> (-2.77%) ⬇️

... and 12 files with indirect coverage changes