Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on goprocess #710

Merged
merged 3 commits into from
Nov 7, 2024

Simplify provide woker goroutines

19d1d6b
Select commit
Loading
Failed to load commit list.
Merged

Remove dependency on goprocess #710

Simplify provide woker goroutines
19d1d6b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

60.35% (-0.03%) compared to 98850cf, passed because coverage increased by 0.08% when compared to adjusted base (60.27%)

View this Pull Request on Codecov

60.35% (-0.03%) compared to 98850cf, passed because coverage increased by 0.08% when compared to adjusted base (60.27%)

Details

Codecov Report

Attention: Patch coverage is 71.22302% with 40 lines in your changes missing coverage. Please review.

Project coverage is 60.35%. Comparing base (98850cf) to head (19d1d6b).

Files with missing lines Patch % Lines
bootstrap/bootstrap.go 39.62% 31 Missing and 1 partial ⚠️
bitswap/server/server.go 85.71% 5 Missing and 1 partial ⚠️
bitswap/client/client.go 81.81% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   60.38%   60.35%   -0.03%     
==========================================
  Files         243      243              
  Lines       31025    31021       -4     
==========================================
- Hits        18733    18724       -9     
- Misses      10625    10633       +8     
+ Partials     1667     1664       -3     
Files with missing lines Coverage Δ
bitswap/bitswap.go 67.05% <100.00%> (-0.39%) ⬇️
bitswap/server/internal/decision/engine.go 91.48% <100.00%> (+0.04%) ⬆️
namesys/republisher/repub.go 61.26% <100.00%> (+2.60%) ⬆️
bitswap/client/client.go 87.93% <81.81%> (-0.14%) ⬇️
bitswap/server/server.go 61.53% <85.71%> (-3.24%) ⬇️
bootstrap/bootstrap.go 30.90% <39.62%> (-1.05%) ⬇️

... and 8 files with indirect coverage changes