fix(gateway): update DoH resolver for .crypto DNSLink #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare decomissionned their resolver and started redirecting (HTTP 308) to https://dns.eth.link/dns-query which is an alias for eth.limo. That endpoint does not support resolving DNSLink of .crypto TLD and always returns no results. This change switched to DoH resolver provided by UD project. Closes #772
lidel
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #782 +/- ##
==========================================
+ Coverage 60.44% 60.54% +0.09%
==========================================
Files 245 245
Lines 31133 31133
==========================================
+ Hits 18818 18848 +30
+ Misses 10638 10615 -23
+ Partials 1677 1670 -7
|
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 7, 2025
2 tasks
lidel
commented
Jan 8, 2025
There was a problem hiding this comment.
CI is green, merging to make the source of UD issues more obvious to users trying to resolve .crypto.
This is provisional fix on our end to allow UD community to fix resolution themselves.
We will keep this status quo for 3-6 months – the future of implicit resolver will be discussed in #772 (comment)
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 14, 2025
commit from main branch that includes: ipfs/boxo#645 ipfs/boxo#782 ipfs/boxo#781
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 14, 2025
* fix(dns): update default DNSLink resolvers Depends on - ipfs/boxo#781 - ipfs/boxo#782 * chore: latest boxo main and go-doh-resolver v0.5.0 makes error message better, informing which URL failled * chore: p2p-forge v0.2.1+ this removes acmez/v2 and fixes go vet * chore: latest boxo with DoH fixes commit from main branch that includes: ipfs/boxo#645 ipfs/boxo#782 ipfs/boxo#781
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 14, 2025
* fix(dns): update default DNSLink resolvers Depends on - ipfs/boxo#781 - ipfs/boxo#782 * chore: latest boxo main and go-doh-resolver v0.5.0 makes error message better, informing which URL failled * chore: p2p-forge v0.2.1+ this removes acmez/v2 and fixes go vet * chore: latest boxo with DoH fixes commit from main branch that includes: ipfs/boxo#645 ipfs/boxo#782 ipfs/boxo#781 (cherry picked from commit b021a00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflare decomissionned their resolver and started redirecting (HTTP 308) to https://dns.eth.link/dns-query which is an alias for eth.limo.
That endpoint does not support resolving DNSLink of
.cryptoTLD and always returns no results, effectively breaking those DNSLinks for everyone using them with IPFS systems.This change switches the default implicit DoH resolver of
.cryptoTLS to one provided by UD project, allowing their community to fix issue without involving a third-party.Allows UD community to fix resolution themselves – see #772