feat: use golangci-lint for code static analysis #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #775,
boxo
requires a better static code analysis tool since the currently usedipdxco/unified-github-workflows
has limitation capabilities.Therefore, I am attempting to use
golangci-lint
here (while retaining the original ipdxco/unified-github-workflows). I have disabled allgolangci-lint
default configurations and enabled some checks that I find particularly valuable.After performing the lint fixes,
boxo
generally has the following issues:gci
can fix this.for example:
boxo/ipld/unixfs/io/dagreader_test.go
Lines 3 to 15 in 8ca0ca2
unconvert
.There might be some other valuable plugins, such as
unused
, and I would like to hear your opinions on them.