-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bitswap): filter interests from received messages #822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggested changes to avoid allocation.
bitswap/client/internal/sessioninterestmanager/sessioninterestmanager.go
Outdated
Show resolved
Hide resolved
bitswap/client/internal/sessioninterestmanager/sessioninterestmanager.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionl change
bitswap/client/internal/sessioninterestmanager/sessioninterestmanager.go
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 60.44% 60.48% +0.04%
==========================================
Files 244 244
Lines 31095 31120 +25
==========================================
+ Hits 18794 18823 +29
+ Misses 10621 10619 -2
+ Partials 1680 1678 -2
|
Co-authored-by: Andrew Gillis <[email protected]>
ee671ff
to
bf8ed5a
Compare
bf8ed5a
to
4ea2f5d
Compare
@guillaumemichel, I think it does and should also fix the DOS vector. P.S. This was really an annoying one to figure out. |
After this PR, 7adce5f should be the last leak to fix |
Fixresource leak by adding a CID to BlockResponseManager only if there a session interested in it.
Follow up to #752
Based on #821
@Wondertan does that address the leak that you are referring to in 70a6503?
cc: @gammazero