Skip to content
This repository has been archived by the owner on Aug 17, 2020. It is now read-only.

switch to persistent peerstore #19

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

switch to persistent peerstore #19

wants to merge 6 commits into from

Conversation

raulk
Copy link
Member

@raulk raulk commented Jul 2, 2019

Perhaps this helps:

[NumDhts: 40, Uptime: 5m0s, Memory Usage: 57 MB, TotalPeers: 737/1213, Total Provs: 0, BootstrapsDone: 3]
[NumDhts: 40, Uptime: 5m5s, Memory Usage: 67 MB, TotalPeers: 736/1225, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m10s, Memory Usage: 77 MB, TotalPeers: 751/1239, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m15s, Memory Usage: 82 MB, TotalPeers: 745/1251, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m20s, Memory Usage: 87 MB, TotalPeers: 729/1260, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m25s, Memory Usage: 90 MB, TotalPeers: 707/1267, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m30s, Memory Usage: 50 MB, TotalPeers: 706/1280, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m35s, Memory Usage: 54 MB, TotalPeers: 681/1285, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m40s, Memory Usage: 58 MB, TotalPeers: 663/1290, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m45s, Memory Usage: 62 MB, TotalPeers: 646/1299, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m50s, Memory Usage: 67 MB, TotalPeers: 639/1309, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 5m55s, Memory Usage: 71 MB, TotalPeers: 633/1322, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 6m0s, Memory Usage: 77 MB, TotalPeers: 616/1333, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 6m5s, Memory Usage: 81 MB, TotalPeers: 602/1335, Total Provs: 0, BootstrapsDone: 32]
[NumDhts: 40, Uptime: 6m10s, Memory Usage: 84 MB, TotalPeers: 583/1342, Total Provs: 0, BootstrapsDone: 32]

@raulk raulk requested review from whyrusleeping and Kubuxu July 2, 2019 13:37
raulk and others added 2 commits July 2, 2019 15:43
@raulk @Kubuxu
switch to persistent peerstore.
61b512b 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Update peerstore
8d1bb00 
To remove bad badger

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu and others added 2 commits July 2, 2019 23:39
@Kubuxu
Add deviation
1098efa 
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@raulk
switch to shared peerstore.
fe34912
Kubuxu
Kubuxu reviewed Jul 3, 2019
View reviewed changes
main.go Outdated
}

opts := pstoreds.DefaultOpts()
opts.CacheSize = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this increase our allocation velocity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but in a shared setup, the cache is useless because it'll just be thrashing all the time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on size and type of cache.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have metrics regarding the hit rate. Unfortunately, open census was disabled because it was allocating too much (Why knows more).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kubuxu Kubuxu Kubuxu left review comments

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulk @Kubuxu