Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11-to-12: Raw multihash migration: improvements to GC and reverts #144

Closed
hsanjuan opened this issue Dec 10, 2021 · 1 comment · Fixed by #145
Closed

11-to-12: Raw multihash migration: improvements to GC and reverts #144

hsanjuan opened this issue Dec 10, 2021 · 1 comment · Fixed by #145
Labels
need/triage Needs initial labeling and prioritization

Comments

@hsanjuan
Copy link
Contributor

I propose:

  • Increasing the number of revert-workers to 4, as there seems to be no reason anymore to keep it in 1 (they have no state that they need to coordinate on anymore)
  • Requiring a patched version of go-ds-badger where the gc cycle interval is set to 2 minutes. Otherwise we will not reclaim any space from deleted blocks as we migrate, which may make migrations fail on setups with little free space available on their disks. Knowing the amount of trash badger writes, this may be really shitty (i.e. badger datastore size rising way beyond 2x for datastore full of CIDv1s).
@hsanjuan hsanjuan added the need/triage Needs initial labeling and prioritization label Dec 10, 2021
@hsanjuan
Copy link
Contributor Author

We should update the notes as this is resolved: ipfs/kubo#8344

@hsanjuan hsanjuan changed the title 11-to-12: Raw multihash migration 11-to-12: Raw multihash migration: improvements to GC and reverts Dec 10, 2021
@lidel lidel mentioned this issue Dec 10, 2021
Closed
59 tasks
@hsanjuan hsanjuan mentioned this issue Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

11 to 12: Improvements to migration ipfs/fs-repo-migrations
1 participant
@hsanjuan