11 to 12: Improvements to migration #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
force-pushed
the
11-12-improvements
branch
from
a503a9e to
844ea5a
Compare
|
This is already rebased on master |
aschmahmann
reviewed
Dec 13, 2021
| @@ -7,6 +7,7 @@ require ( | |||
| github.com/ipfs/fs-repo-migrations/tools v0.0.0-20211209222258-754a2dcb82ea | |||
| github.com/ipfs/go-cid v0.0.7 | |||
| github.com/ipfs/go-datastore v0.4.5 | |||
| github.com/ipfs/go-ds-badger v0.2.7-0.20211210151007-a2805355dcf5 // indirect | |||
There was a problem hiding this comment.
The reliance on a non-tagged commit shouldn't hurt us here since we're using vendoring, right?
aschmahmann
reviewed
Dec 13, 2021
| // this only works with a single worker. Otherwise we'd need | ||
| // complex syncing, or delayed removal (increased datastore size). | ||
| return cswap.runWorkers(1, swapWorkerFunc) | ||
| return cswap.runWorkers(NWorkers, swapWorkerFunc) |
There was a problem hiding this comment.
From @hsanjuan: The logic for why we only needed 1 worker is not true anymore. Before we kept track of whether a reverted block had a v0 reference so we did not delete the v0... but now we don't delete anything on revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144