Use the current path to go-migrate #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
approved these changes
Dec 10, 2021
aschmahmann
reviewed
Dec 10, 2021
fs-repo-11-to-12/go.mod
Outdated
| @@ -4,12 +4,11 @@ go 1.15 | |||
|
|
|||
| require ( | |||
| github.com/hsanjuan/ipfs-lite v1.1.19 | |||
| github.com/ipfs/fs-repo-migrations v1.7.1 | |||
| github.com/ipfs/fs-repo-migrations/tools v0.0.0-20210323144402-297a63449538 | |||
There was a problem hiding this comment.
Any reason we're not using a released version here?
There was a problem hiding this comment.
I'm not even sure this is in master, might just be on your local machine from when we did this last time
There was a problem hiding this comment.
I cannot use a version tag, as the module is not in the root of the repo.
go get: module github.com/ipfs/[email protected] found (v2.0.2+incompatible), but does not contain package github.com/ipfs/fs-repo-migrations/tools
If I update to the commit of v2.0.2, that gives me:
github.com/ipfs/fs-repo-migrations/tools v0.0.0-20210617204053-ea2bc1a62948
So, we can use that if you prefer.
|
This has failed for something stupid, I'm merging and rebasing #145 on top, and we take those tests as proper signal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.