Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use prefix iterators for Get/Has()" #28

Merged
merged 4 commits into from
Nov 23, 2023
Merged

Revert "Use prefix iterators for Get/Has()" #28

merged 4 commits into from
Nov 23, 2023

Conversation

hsanjuan
Copy link
Contributor

Upon testing this on high concurrency scenario, it would seem that this makes reading very very slow in comparison to the previous implementation (ie. 50 vs 3000 ipfs block-reads per second).

For this reason we must revert.

@hsanjuan
Copy link
Contributor Author

Hmmm i think things may slow down too even with this reverted 😢

Upon testing this on high concurrency scenario, it would seem that this makes
reading very very slow in comparison to the previous implementation (ie. 50 vs
3000 ipfs block-reads per second).

For this reason we must revert.
Latest version uses bloom-filters on get.

See: cockroachdb/pebble#197
Copy link

Suggested version: v0.2.5

Comparing to: v0.2.4 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index 4eb1c16..2de2b87 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
 module github.com/ipfs/go-ds-pebble
 
-go 1.19
+go 1.20
 
 require (
 	github.com/cockroachdb/pebble v0.0.0-20230227185959-8285e8dd5c08

gorelease says:

# diagnostics
required module github.com/kataras/iris/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon. Please update to @latest
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.3.0

gocompat says:

Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@hsanjuan hsanjuan merged commit aee84dc into master Nov 23, 2023
7 checks passed
@hsanjuan hsanjuan deleted the slow-get branch November 23, 2023 20:57
@hsanjuan
Copy link
Contributor Author

This is merged because upstream pebble uses bloom filters now, so we don't need to complicate things here.

See: cockroachdb/pebble#197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant