add a Poll function to node promises #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and improve the documentation)
ghost
assigned 
Kubuxu
reviewed
Jul 9, 2018
promise.go
Outdated
| @@ -51,6 +53,16 @@ func (np *NodePromise) Send(nd Node) { | |||
| close(np.done) | |||
| } | |||
|
|
|||
| // Poll returns the result of the promise if ready but doesn't block. | |||
| func (np *NodePromise) Poll() (Node, error) { | |||
There was a problem hiding this comment.
I'm not sure about the name.
poll (2) in Linux is blocking.
There was a problem hiding this comment.
Both java and rust use a poll function to check futures without waiting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and improve the documentation)
This'll allow us to test for canceled promises and fix the todo in
ipfs/kubo#5162.
Obviously, this is ultra low priority as we're not going to run into that case
in practice for a while (if ever). However, this function still feels useful.