feat: add check using only a CID #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/main: chore: bump go.mod to Go 1.22 and run go fix (#51) chore: port version.go from rainbow chore: bump libp2p and kad-dht fix: make overflown text scroll chore: go-libp2p-kad-dht v0.26.1 chore: first release
|
Example test result |
lidel
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Thank you @2color! Small suggestions inline, but feel free to ship and deploy to prod 🙏
I think this is a good incremental improvement that delivers important feature (testing CID's availability without knowing specific provider).
We can enhance it in future but just shipping this as-is is already a big win for anyone trying to debug things.
ps. I did a small cleanup in #55 but it is not related to this PR.
Comment on lines
+93
to
+96
| if maStr == "" { | ||
| data, err = d.runCidCheck(r.Context(), cidStr) | ||
| } else { | ||
| data, err = d.runPeerCheck(r.Context(), maStr, cidStr) |
There was a problem hiding this comment.
Not a blocker, but I think we may want to time-bound these with some sane timeout.
I've filled #54 to tackle that in future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
This PR fixes #6
PeerFoundInDHTin favour of a simpler array ofMaddrscontaining the maddrs for each provider (without the observed address count) and removingCidInDHTwhich is redundant for this check (see Rename CIDinDHT to ProviderRecordFromPeerInDHT #52)Other approaches explored but decided against
Exposing a delegated routing endpoint and reusing the existing CID & Maddr endpoint
In this approach, given a CID by the user, the frontend would make a delegated routing providers request and then issue multiple check requests for each provider returned. This would make the frontend a bit more logic heavy. However, after some initial exploration, I decided against it for a number of reasons:
CidInDHTwhich adds overhead to