-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: match documentation with ipfs desktop button label #1907
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There are two broken links on that page that need to be fixed so that the linter can pass: |
what happened to/who owns the domain/url? i acknowledge that it has an error, but pinning HTML files in Pinata requires a paid plan. im just submitting a PR for a typo. how should i update the doc? removing the section on the domain and everything referencing it seems counter to the page's purpose |
@davidlfox these errors are not your fault, the problem is that CI automation runs tests against modified files, and if a file was not modified for a while, it is possible that some links no longer work, and the first time we detect that is here. In this case, let's just remove paragraph with broken links. The website does not need to exist for the tutorial to make sense. |
Describe your changes
Just a language match between what's in IPFS desktop app and the documentation
Files changed
What issue(s) does this address?
Does this update depend on any other PRs?
Checklist before requesting a review
Checklist before merging