Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match documentation with ipfs desktop button label #1907

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

davidlfox
Copy link
Contributor

Describe your changes

Just a language match between what's in IPFS desktop app and the documentation

Files changed

  • docs/how-to/websites-on-ipfs/single-page-website.md

What issue(s) does this address?

  • good documentation

Does this update depend on any other PRs?

  • not from what I can tell

Checklist before requesting a review

  • [✅ ] Passing the beta version of the Check Markdown links for modified files check. Action results can be viewed here.

Checklist before merging

  • [ ✅] Passing all required checks (The beta Check Markdown links for modified files check is not required)

Copy link

welcome bot commented Aug 2, 2024

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
  • Your contribution itself is clear (grammar and spelling checked, any code blocks checked and commented) and in its best form. Follow the docs contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
  • The PR gets reviews, discussed and approvals as needed.
  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@ipfs ipfs deleted a comment from ELALEMAN007 Aug 7, 2024
Copy link
Member

@2color 2color left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@2color
Copy link
Member

2color commented Aug 7, 2024

There are two broken links on that page that need to be fixed so that the linter can pass:
FILE: docs/how-to/websites-on-ipfs/single-page-website.md
[✖] http://randomplanetfacts.xyz/ → Status: 403
[✖] https://gateway.pinata.cloud/ipfs/QmW7S5HRLkP4XtPNyT1vQSjP3eRdtZaVtF6FAPvUfduMjA → Status: 403

@davidlfox
Copy link
Contributor Author

There are two broken links on that page that need to be fixed so that the linter can pass: FILE: docs/how-to/websites-on-ipfs/single-page-website.md [✖] http://randomplanetfacts.xyz/ → Status: 403 [✖] https://gateway.pinata.cloud/ipfs/QmW7S5HRLkP4XtPNyT1vQSjP3eRdtZaVtF6FAPvUfduMjA → Status: 403

what happened to/who owns the domain/url? i acknowledge that it has an error, but pinning HTML files in Pinata requires a paid plan. im just submitting a PR for a typo. how should i update the doc? removing the section on the domain and everything referencing it seems counter to the page's purpose

@lidel
Copy link
Member

lidel commented Aug 9, 2024

@davidlfox these errors are not your fault, the problem is that CI automation runs tests against modified files, and if a file was not modified for a while, it is possible that some links no longer work, and the first time we detect that is here.

In this case, let's just remove paragraph with broken links. The website does not need to exist for the tutorial to make sense.

@lidel lidel changed the title match documentation with ipfs desktop button label fix: match documentation with ipfs desktop button label Aug 9, 2024
@lidel lidel merged commit 1ff615e into ipfs:main Aug 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants