test: sharness without tcp mux

ipfs · Dec 19, 2024 · b5cfd6d · b5cfd6d
1 parent a436f4e
commit b5cfd6d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.github/workflows/sharness.yml b/.github/workflows/sharness.yml
@@ -52,6 +52,7 @@ jobs:
           TEST_EXPENSIVE: 1
           IPFS_CHECK_RCMGR_DEFAULTS: 1
           CONTINUE_ON_S_FAILURE: 1
+          LIBP2P_TCP_MUX: false # TODO
           # increasing parallelism beyond 10 doesn't speed up the tests much
           PARALLEL: ${{ github.repository == 'ipfs/kubo' && 10 || 3 }}
       - name: Upload coverage report

diff --git a/core/node/libp2p/transport.go b/core/node/libp2p/transport.go
@@ -2,6 +2,8 @@ package libp2p
 
 import (
 	"fmt"
+	"os"
+
 	"github.com/ipfs/kubo/config"
 	"github.com/ipshipyard/p2p-forge/client"
 	"github.com/libp2p/go-libp2p"
@@ -66,7 +68,7 @@ func Transports(tptConfig config.Transports) interface{} {
 			opts.Opts = append(opts.Opts, libp2p.Transport(webrtc.New))
 		}
 
-		if tcpEnabled && wsEnabled {
+		if tcpEnabled && wsEnabled && os.Getenv("LIBP2P_TCP_MUX") != "false" {
 			opts.Opts = append(opts.Opts, libp2p.ShareTCPListener())
 		}
 

diff --git a/docs/environment-variables.md b/docs/environment-variables.md
@@ -155,7 +155,14 @@ Kubo tries to reuse the same source port for all connections to improve NAT
 traversal. If this is an issue, you can disable it by setting
 `LIBP2P_TCP_REUSEPORT` to false.
 
-Default: true
+Default: `true`
+
+## `LIBP2P_TCP_MUX`
+
+Kubo tries to reuse the same listener port for raw TCP and WebSockers transports.
+If this is an issue, you can disable it by setting `LIBP2P_TCP_MUX` to `false`.
+
+Default: `true`
 
 ## `LIBP2P_MUX_PREFS`