Merge pull request #5459 from ipfs/fix/5458

fix output of object command
ipfs · Sep 13, 2018 · cb589a3 · cb589a3
2 parents cf96372 + 5629b1c
commit cb589a3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/core/commands/object/object.go b/core/commands/object/object.go
@@ -160,7 +160,7 @@ multihash.
 			}
 		}
 
-		out := Object{
+		out := &Object{
 			Hash:  rp.Cid().String(),
 			Links: outLinks,
 		}
@@ -183,10 +183,10 @@ multihash.
 			w := tabwriter.NewWriter(buf, 1, 2, 1, ' ', 0)
 			headers, _, _ := res.Request().Option("headers").Bool()
 			if headers {
-				fmt.Fprintln(w, "Hash\tSize\tName\t")
+				fmt.Fprintln(w, "Hash\tSize\tName")
 			}
 			for _, link := range object.Links {
-				fmt.Fprintf(w, "%s\t%v\t%s\t\n", link.Hash, link.Size, link.Name)
+				fmt.Fprintf(w, "%s\t%v\t%s\n", link.Hash, link.Size, link.Name)
 			}
 			w.Flush()
 			return buf, nil

diff --git a/test/sharness/t0051-object.sh b/test/sharness/t0051-object.sh
@@ -223,6 +223,12 @@ test_object_cmd() {
     ipfs object stat $OUTPUT
   '
 
+  test_expect_success "'ipfs object links' gives the correct results" '
+    echo "$EMPTY_DIR" 4 foo > expected &&
+    ipfs object links "$OUTPUT" > actual &&
+    test_cmp expected actual
+  '
+
   test_expect_success "'ipfs object patch add-link' should work with paths" '
     EMPTY_DIR=$(ipfs object new unixfs-dir) &&
     N1=$(ipfs object patch $EMPTY_DIR add-link baz $EMPTY_DIR) &&