-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] WASM IPLD Codecs and ADLs #9016
Draft
aschmahmann
wants to merge
12
commits into
master
Choose a base branch
from
exp/wasm-ipld
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
eab36cc
hack: load bittorrent files over gateways
aschmahmann bcc3771
ipldwasm
aschmahmann 27c9731
wasm with wac codec
aschmahmann 13122f9
wac some adls
aschmahmann 3b51106
wasm fuel + cleanup
aschmahmann 6a2aaec
draft wac spec
aschmahmann 9bf4dd2
fix wac encoding, and switch for now use an already reserved code name
aschmahmann 61259ad
switch to separate wasmlib
aschmahmann b2ad3f5
remove bittorrent specifics
aschmahmann 1d39402
make adls and codecs configurable from the config file
aschmahmann b402ea4
point at public commit
aschmahmann 89af104
feat: use draft IPLD URI
aschmahmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| package corehttp | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/ipfs/go-cid" | ||
| "net/http" | ||
| "time" | ||
|
|
||
| "go.uber.org/zap" | ||
|
|
||
| ipath "github.com/ipfs/interface-go-ipfs-core/path" | ||
|
|
||
| dagpb "github.com/ipld/go-codec-dagpb" | ||
| "github.com/ipld/go-ipld-prime" | ||
| "github.com/ipld/go-ipld-prime/datamodel" | ||
| cidlink "github.com/ipld/go-ipld-prime/linking/cid" | ||
| "github.com/ipld/go-ipld-prime/node/basicnode" | ||
| "github.com/ipld/go-ipld-prime/traversal" | ||
| "github.com/ipld/go-ipld-prime/traversal/selector" | ||
| ) | ||
|
|
||
| func (i *gatewayHandler) serveIPLD(w http.ResponseWriter, r *http.Request, resolvedPath ipath.Resolved, contentPath ipath.Path, selectorNode ipld.Node, selectorCID cid.Cid, begin time.Time, logger *zap.SugaredLogger) { | ||
| if resolvedPath.Remainder() != "" { | ||
| http.Error(w, "serving ipld cannot handle path remainders", http.StatusInternalServerError) | ||
| return | ||
| } | ||
|
|
||
| nsc := func(lnk ipld.Link, lctx ipld.LinkContext) (ipld.NodePrototype, error) { | ||
| // We can decode all nodes into basicnode's Any, except for | ||
| // dagpb nodes, which must explicitly use the PBNode prototype. | ||
| if lnk, ok := lnk.(cidlink.Link); ok && lnk.Cid.Prefix().Codec == 0x70 { | ||
| return dagpb.Type.PBNode, nil | ||
| } | ||
| return basicnode.Prototype.Any, nil | ||
| } | ||
|
|
||
| compiledSelector, err := selector.CompileSelector(selectorNode) | ||
| if err != nil { | ||
| webError(w, "could not compile selector", err, http.StatusInternalServerError) | ||
| return | ||
| } | ||
|
|
||
| lnk := cidlink.Link{Cid: resolvedPath.Cid()} | ||
| ns, _ := nsc(lnk, ipld.LinkContext{}) // nsc won't error | ||
|
|
||
| type HasLinksystem interface { | ||
| LinkSystem() ipld.LinkSystem | ||
| } | ||
|
|
||
| lsHaver, ok := i.api.(HasLinksystem) | ||
| if !ok { | ||
| webError(w, "could not find linksystem", err, http.StatusInternalServerError) | ||
| return | ||
| } | ||
| lsys := lsHaver.LinkSystem() | ||
|
|
||
| nd, err := lsys.Load(ipld.LinkContext{Ctx: r.Context()}, lnk, ns) | ||
| if err != nil { | ||
| webError(w, "could not load root", err, http.StatusInternalServerError) | ||
| return | ||
| } | ||
|
|
||
| prog := traversal.Progress{ | ||
| Cfg: &traversal.Config{ | ||
| Ctx: r.Context(), | ||
| LinkSystem: lsys, | ||
| LinkTargetNodePrototypeChooser: nsc, | ||
| LinkVisitOnlyOnce: true, | ||
| }, | ||
| } | ||
|
|
||
| var latestMatchedNode ipld.Node | ||
|
|
||
| err = prog.WalkAdv(nd, compiledSelector, func(progress traversal.Progress, node datamodel.Node, reason traversal.VisitReason) error { | ||
| if reason == traversal.VisitReason_SelectionMatch { | ||
| if latestMatchedNode == nil { | ||
| latestMatchedNode = node | ||
| } else { | ||
| return fmt.Errorf("can only use selectors that match a single node") | ||
| } | ||
| } | ||
| return nil | ||
| }) | ||
| if err != nil { | ||
| webError(w, "could not execute selector", err, http.StatusInternalServerError) | ||
| return | ||
| } | ||
|
|
||
| if latestMatchedNode == nil { | ||
| webError(w, "selector did not match anything", err, http.StatusInternalServerError) | ||
| return | ||
| } | ||
|
|
||
| lbnNode, ok := latestMatchedNode.(datamodel.LargeBytesNode) | ||
| if !ok { | ||
| webError(w, "matched node was not bytes", err, http.StatusInternalServerError) | ||
| return | ||
| } | ||
| if data, err := lbnNode.AsLargeBytes(); err != nil { | ||
| webError(w, "matched node was not bytes", err, http.StatusInternalServerError) | ||
| return | ||
| } else { | ||
| modtime := addCacheControlHeaders(w, r, contentPath, resolvedPath.Cid()) | ||
| name := resolvedPath.Cid().String() + "-" + selectorCID.String() | ||
| http.ServeContent(w, r, name, modtime, data) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's regret around the structure we ended up here - with links in practice needing to be cidlink.Link but doing this check of it every time to pull out the Cid.
Instead, I think the pattern ipld-prime has been hoping to transition to is to use
cid.Cast(link.Binary())There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, I thought this pattern is what we've got at the moment. Also, wouldn't
cid.Castdo parsing again?