Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure ConnMgr is smaller than autoscalled ResourceMgr limits #9555

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: ensure ConnMgr is smaller than autoscalled ResourceMgr limits #9555

merged 1 commit into from
Jan 20, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 16, 2023

Fixes #9545

@Jorropo Jorropo changed the title fix: account for high water when setting autoscalled default ressource limits fix: ensure connmgr is smaller then autoscalled ressource limits Jan 16, 2023
@lidel lidel changed the title fix: ensure connmgr is smaller then autoscalled ressource limits fix: ensure ConnMgr is smaller then autoscalled ResourceMgr limits Jan 16, 2023
@lidel lidel changed the title fix: ensure ConnMgr is smaller then autoscalled ResourceMgr limits fix: ensure ConnMgr is smaller than autoscalled ResourceMgr limits Jan 16, 2023
@Jorropo Jorropo mentioned this pull request Jan 16, 2023
Open
3 tasks
@Jorropo Jorropo requested a review from lidel January 16, 2023 17:25
@lidel lidel mentioned this pull request Jan 17, 2023
Closed
@ajnavarro ajnavarro mentioned this pull request Jan 18, 2023
Closed
BigLep
BigLep reviewed Jan 19, 2023
View reviewed changes
core/node/libp2p/rcmgr_defaults.go Outdated Show resolved Hide resolved
core/node/libp2p/rcmgr_defaults.go Show resolved Hide resolved
core/node/libp2p/rcmgr_defaults.go Show resolved Hide resolved
docs/libp2p-resource-management.md Outdated Show resolved Hide resolved
docs/libp2p-resource-management.md Outdated Show resolved Hide resolved
docs/libp2p-resource-management.md Outdated Show resolved Hide resolved
core/node/libp2p/rcmgr_defaults.go Show resolved Hide resolved
docs/libp2p-resource-management.md Outdated Show resolved Hide resolved
BigLep
BigLep reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to get a note about the extra logic we're doing here for 800 without having to write out the specifics. Someone can look at the code if they really care. This at least gives the clue that there is more going on.

docs/libp2p-resource-management.md Show resolved Hide resolved
lidel
lidel requested changes Jan 19, 2023
View reviewed changes
config/init.go Show resolved Hide resolved
@Jorropo Jorropo requested review from BigLep, ajnavarro and lidel January 19, 2023 13:07
BigLep
BigLep approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let others approve the code but the docs look good to me.

@Jorropo
Copy link
Contributor Author

Jorropo commented Jan 20, 2023

Downloaded SaxonHE11-4J.zip has wrong md5sum ('9f12926355f7d0c2b92ba3c826a05bba' != '8a4783d307c32c898f8995b8f337fd6b')

@Jorropo Jorropo merged commit 8328bab into ipfs:master Jan 20, 2023
@Jorropo Jorropo deleted the fix/9545 branch January 20, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnavarro ajnavarro ajnavarro left review comments

@BigLep BigLep BigLep approved these changes

@lidel lidel Awaiting requested review from lidel

Assignees
No one assigned
Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Computed default ResourceMgr limits account for ConnMgr HighWater and are sufficiently high
4 participants
@Jorropo @BigLep @lidel @ajnavarro