Skip to content
This repository has been archived by the owner on Jan 31, 2025. It is now read-only.

Should not tell me to merge the Release PR for RCs #29

Closed
hacdias opened this issue Jan 11, 2024 · 0 comments · Fixed by #33
Closed

Should not tell me to merge the Release PR for RCs #29

hacdias opened this issue Jan 11, 2024 · 0 comments · Fixed by #33
Assignees
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours P3 Low: Not priority right now

Comments

@hacdias
Copy link
Collaborator

hacdias commented Jan 11, 2024

The release PR (e.g. ipfs/kubo#10287) generated by kuboreleaser should only be merged for the final release as per the release instructions: https://github.com/ipfs/kubo/blob/02ea51872b9258a95d549ea8116c739be796cb65/docs/RELEASE_ISSUE_TEMPLATE.md?plain=1#L87-L105

However, kuboreleaser asks me to merge it for pre-releases too:

$ ./kuboreleaser --skip-check-before release --version v0.26.0-rc1 prepare-branch
INFO[2024-01-11 08:13:51] Skipping the check before running the action
INFO[2024-01-11 08:13:51] Running the action...
INFO[2024-01-11 08:13:51] I'm going to create PRs that update the version in the release branch and the master branch.
INFO[2024-01-11 08:13:51] I'm also going to update the changelog if we're performing the final release. Please note that it might take a while because I have to clone a looooot of repos.
Your release PR is ready at https://github.com/ipfs/kubo/pull/10287
If needed, check out the release-v0.26.0 branch of ipfs/kubo repository and cherry-pick commits from master using the following command:

git cherry-pick -x <commit>

Please approve after all the required commits are cherry-picked.

Only 'yes' will be accepted to approve.

Enter a value: yes
Go to https://github.com/ipfs/kubo/pull/10288, ensure the CI checks pass, and merge the PR.

Please approve once the PR is merged.

Only 'yes' will be accepted to approve.

Enter a value:
@hacdias hacdias self-assigned this Jan 23, 2024
@hacdias hacdias added dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours labels Jan 23, 2024
@hacdias hacdias moved this to 🥞 Todo in IPFS Shipyard Team Jan 23, 2024
@hacdias hacdias added the P3 Low: Not priority right now label Jan 25, 2024
@github-project-automation github-project-automation bot moved this from 🥞 Todo to 🎉 Done in IPFS Shipyard Team Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours P3 Low: Not priority right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant