-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generates parts of the dashboard async, using ipfs/gateway-conformance #442
Comments
Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
Finally, remember to use https://discuss.ipfs.io if you just need general support. |
(self-assigning, I'll take the responsibility of moving this work forward, but happy to collaborate) |
Thanks for submitting this story @laurentsenta, excellent effort, we can pair on this if you'd like! Can we mark these issues as duplicate/subtask of this issue (as I feel these can have a potential overlap):
CC: @SgtPooki |
@SgtPooki @whizzzkid I updated the plan and prepared the PR for the CI side. @lidel currently the gateway check looks like this: the conformance test suite granularity is much finer: Proposal: we define Related PR: ipfs/gateway-conformance#130 |
note from call with @whizzzkid & @galargh
|
Thanks for updating @laurentsenta . A couplde of drive-by comments (don't block on me)... In #442 (comment) you took a screenshot including Gateway implementations rather than gateway instances. I assume that was just for convenience right? This issue concerns conformance metadata for gateway instances right? Lots of interesting ideas in #442 (comment). Which of these are we actually committing to? I want to make sure we don't move the goal post. Most (all?) those things seem like potential followups. I want us to get to a place where gateway checker red screen of death is gone and then we can evaluate what to do next. (I think at that point it will make sense to shift to higher impact areas.) |
@BigLep apologies, I forgot to press "send" on my answer,
Yes, this is in relation to a discussion regarding metadata in gateway conformance (comment). The screenshot points out the difference between gateway conformance details (10+ groups) vs gateway checker level of details (4 test groups). Yesterday we ack'd with @lidel the need for a "Taxonomie for End Users" that is different from the "Taxonomie for Specs Maintainers".
Definitely. I'm working on matching features with the current workflow, the rest is nice-to-have or follow-up |
Contributes to #442 - create a `gateways.txt` file we can import from Ci - use the `report.json` in the frontend instead of `gateways.ts` (single source of truth) - call the conformance workflow for every gateway - gather results into a single job - aggregates all these results into assets we can load in the frontend - generate intermediate step output per gateway if possible - define the "right" workflow to commit `report.json` - generate a minimal output.md in the action - find a way to "hide" the failure state on expected failure (not all tests passing) - undo the dependency on gateway fork (needs the dashboard PR)
The ipfs/gateway-conformance has reached a point where we should be able to generate most of the info needed by our public gateway checker. Reusing the project should reduce maintenance and avoid the "Red Message Of Death" caused by the user's browser connecting with many gateways.
Interop
conformance.json:
CI: Call the gateway conformance workflow - #450
@laurentsenta
e2e production workflow
CI: Generate metadata (country) on the server side - #451
Frontend: Render the results
Make the tests pass
Follow-ups
The text was updated successfully, but these errors were encountered: