Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate results with gateway-conformance #450

Merged
merged 44 commits into from
Sep 29, 2023
Merged

feat: generate results with gateway-conformance #450

merged 44 commits into from
Sep 29, 2023

Conversation

laurentsenta
Copy link
Contributor

@laurentsenta laurentsenta commented Aug 22, 2023 •
edited
Loading

Contributes to #442

Work in progress, see runs in fork, large run

  • create a gateways.txt file we can import from Ci
  • use the report.json in the frontend instead of gateways.ts (single source of truth)
  • call the conformance workflow for every gateway
  • gather results into a single job
  • aggregates all these results into assets we can load in the frontend
  • generate intermediate step output per gateway if possible
  • define the "right" workflow to commit report.json
  • generate a minimal output.md in the action
  • find a way to "hide" the failure state on expected failure (not all tests passing)
  • undo the dependency on gateway fork (needs the dashboard PR)

@laurentsenta laurentsenta requested a review from a team as a code owner August 22, 2023 10:02
@welcome

This comment was marked as off-topic.

Sign in to view
@laurentsenta laurentsenta marked this pull request as draft August 22, 2023 10:03
@laurentsenta laurentsenta mentioned this pull request Aug 22, 2023
Open
13 tasks
@laurentsenta laurentsenta force-pushed the master branch 2 times, most recently from 3a1fb24 to 8592b5a Compare August 22, 2023 12:11
SgtPooki
SgtPooki requested changes Aug 22, 2023
View reviewed changes
src/gateways.json Outdated Show resolved Hide resolved
@laurentsenta laurentsenta force-pushed the master branch 10 times, most recently from 20a5236 to 90535b1 Compare August 28, 2023 10:19
@laurentsenta laurentsenta mentioned this pull request Aug 31, 2023
Merged
@laurentsenta laurentsenta force-pushed the master branch 5 times, most recently from 3a81362 to a6b92a4 Compare August 31, 2023 14:59
@laurentsenta laurentsenta marked this pull request as ready for review September 1, 2023 13:44
galargh
galargh approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

gateways.yml Outdated Show resolved Hide resolved
.github/workflows/gateway-conformance.yml Outdated Show resolved Hide resolved
.github/workflows/gateway-conformance.yml Outdated Show resolved Hide resolved
.github/workflows/gateway-conformance.yml Show resolved Hide resolved
SgtPooki
SgtPooki reviewed Sep 29, 2023
View reviewed changes
.github/aggregate.ts Outdated Show resolved Hide resolved
SgtPooki
SgtPooki reviewed Sep 29, 2023
View reviewed changes
.github/aggregate.ts Outdated Show resolved Hide resolved
SgtPooki
SgtPooki reviewed Sep 29, 2023
View reviewed changes
.github/aggregate.ts Outdated Show resolved Hide resolved
SgtPooki
SgtPooki reviewed Sep 29, 2023
View reviewed changes
.github/aggregate.ts Outdated Show resolved Hide resolved
@laurentsenta @SgtPooki
Update .github/aggregate.ts
ed41396 
Co-authored-by: Russell Dempsey <[email protected]>
whizzzkid
whizzzkid approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one file ending can be corrected.

@laurentsenta laurentsenta merged commit e200e3a into ipfs:master Sep 29, 2023
github-actions bot pushed a commit that referenced this pull request Sep 29, 2023
@semantic-release-bot
chore(release): 1.8.0 [skip ci]
eaa3ebe 
## [1.8.0](v1.7.0...v1.8.0) (2023-09-29)

### Features

* generate results with gateway-conformance ([#450](#450)) ([e200e3a](e200e3a)), closes [#442](#442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel left review comments

@SgtPooki SgtPooki SgtPooki approved these changes

@galargh galargh galargh approved these changes

@whizzzkid whizzzkid whizzzkid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laurentsenta @SgtPooki @lidel @whizzzkid @galargh