Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate results with gateway-conformance #450
feat: generate results with gateway-conformance #450
Changes from 37 commits
cb1b5f6
0f332e6
4be2a90
75a0d5c
ea0153b
9323240
f24e634
aa5f7ad
5dc6bc0
6bfd3b9
ddf426a
21b84fb
b48343c
bcbaba0
25c145a
e1eab98
abee69b
d18db7a
100885a
0418110
d1a5c1d
f9cbd4e
8bb82b8
3ff77da
050c93e
0525cf3
34f0799
202ccf6
1d82c2d
d94ff85
3d5b97d
769efaf
72bf302
7495bdd
43aed13
05814b5
094d4a4
dddc836
ed41396
543a529
8a1ef93
267c2e0
65bcf8d
6c29ab6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be made into a script, or better create an
actions
folder in a common repo an d use that. Aegir does that like: https://github.com/ipfs/aegir/tree/master/actionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case of aegir, it's reused multiple times,
https://github.com/search?q=ipfs%2Faegir%2Factions%2Fcache-node-modules&type=code
Here that piece of shell is the other end of a pipe we created when we generated the json reports in the matrix above.
What would be the rationale for abstracting this into scripts and/or actions? My intuition is that this moves away code that is tightly coupled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we can reuses conformance tests elsewhere if need be?