Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): --version match release git tag #146

Closed
wants to merge 1 commit into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 11, 2024

This makes rainbow --version in docker images be prefixed with the value from release git tag. Non-Docker and developer builds will have the old value.

Example

$ docker run --rm -it --net=host rainbow-test-v99 --version
rainbow version v99.0.0/2024-06-11-981f80e

$ docker run --rm -it --net=host rainbow-test-v99-dirty --version
rainbow version v99.0.0/2024-06-11-981f80e-dirty

$ docker run --rm -it --net=host rainbow-test-main-dev-build --version
rainbow version 2024-06-11-1d56b9b

Requires below to land first:

Closes #145

@lidel lidel changed the title fix(docker): version match git tag fix(docker): version match release git tag Jun 11, 2024
@lidel lidel changed the title fix(docker): version match release git tag fix(docker): --version match release git tag Jun 11, 2024
@lidel lidel marked this pull request as ready for review June 11, 2024 16:13
@lidel lidel force-pushed the fix/set-version-to-git-tag-on-docker-builds branch from 981f80d to 103bf3f Compare June 11, 2024 16:13
@lidel
Copy link
Member Author

lidel commented Jun 20, 2024

Superseded by more generic #149

@lidel lidel closed this Jun 20, 2024
@lidel lidel deleted the fix/set-version-to-git-tag-on-docker-builds branch June 20, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make --version return tagged version on release builds
1 participant