-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pebble datastore #166
Conversation
Added cli flags for all peble configuration options. Setting any to the zero-value for the type will cause Pebble's devauld value to be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! looks sensible enough to do A/B test in staging before continuing. I mainly want to see if Pebble's internal compaction is enough for Rainbow's use case, or do we need to explicitly call it in gc.go
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
Co-authored-by: Marcin Rataj <[email protected]>
There is no need to explicitly do compaction in a GC cycle with pebble. If there is a very high constant influx of data, and the compaction is not catching up, then tuning parameters can be adjusted as needed. |
Added cli flags for all peble configuration options. Setting any to the zero-value for the type will cause Pebble's devauld value to be used.