Separate Fullscreen Functionality from Shortcut Key Activation #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Previously, the application's fullscreen toggle was inherently linked to the Alt+Ctrl+Enter keyboard shortcut. This posed an issue where if the shortcut was already registered by another program, activating the shortcut would unintentionally trigger the fullscreen functionality in this application as well. Users experienced unintended behavior due to this global shortcut conflict.
Resolution:
To address this issue, this PR decouples the fullscreen toggle from the Alt+Ctrl+Enter shortcut. It introduces a new menu option that allows users to enable or disable the fullscreen shortcut independently of the fullscreen functionality itself.
Benefits:
This change improves the application's compatibility and prevents conflicts with other applications that might use the same global shortcut.
Screenshots:
Before:
Atfter: