Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EOF testing completeness matrix #149

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add EOF testing completeness matrix #149

merged 1 commit into from
Aug 8, 2024

Conversation

pdobacz
Copy link
Member

@pdobacz pdobacz commented Aug 5, 2024

Kind request to implementation owners to double-check if mentioned revisions of tests pass and provide input on completeness (apologies if my first take is off here, also I have no accurate knowledge on erigon/geth/nethermind/EELS).

Also, if any other client is exporting fixtures like evmone, feel free to let know and add to the table (this is to enable us to find issues earlier, meanwhile work on providing coverage with EEST is ongoing)

@pdobacz pdobacz requested a review from gumb0 August 5, 2024 11:30
@pdobacz pdobacz self-assigned this Aug 5, 2024
@gumb0
Copy link
Contributor

gumb0 commented Aug 5, 2024

@pdobacz
Copy link
Member Author

pdobacz commented Aug 5, 2024

What abot https://github.com/ipsilon/execution-spec-tests/releases/tag/eip7692%40v1.0.4%2Bipsilon_bf37249b, is this worth adding?

Nope it's an interim release to get past CI hurdles on evmone's side exclusively. Actually, I'm wondering if maybe we shouldn't delete those releases, so that no one runs into them (see the notice on the prerelase)

@racytech
Copy link
Contributor

racytech commented Aug 7, 2024

Erigon is passing EOF tests for now, soon state tests should pass as well

@pdobacz
Copy link
Member Author

pdobacz commented Aug 7, 2024

Erigon is passing EOF tests for now, soon state tests should pass as well

@racytech can you be more specific, do you mean all 3 "kinds" of EOF tests in the versions specified in the table?

@pdobacz pdobacz force-pushed the testing-matrix branch 2 times, most recently from bc44f88 to b687aa1 Compare August 8, 2024 15:24
@pdobacz
Copy link
Member Author

pdobacz commented Aug 8, 2024

OK, I'll merge this with a few ones I'm uncertain about and please file PRs if anything is off or out-of-date

@pdobacz pdobacz merged commit ad3d34f into main Aug 8, 2024
2 checks passed
@pdobacz pdobacz deleted the testing-matrix branch August 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants