-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson improvement #620
Meson improvement #620
Conversation
Reviewer's Guide by SourceryThis pull request improves the Meson build configuration for the iptux project. The changes include updating the Meson version requirement, adding summary sections for directories, dependencies, and options, and modifying test configurations to use the 'gtest' protocol. Additionally, there are updates to the handling of paths and dependencies in various meson.build files. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lidaobing - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
share/metainfo/meson.build
Outdated
@@ -23,9 +23,9 @@ metainfo_i18n = i18n.merge_file( | |||
input: metainfo_with_relinfo, | |||
output: 'io.github.iptux_src.iptux.metainfo.xml', | |||
type: 'xml', | |||
po_dir: join_paths(meson.source_root(), 'po'), | |||
po_dir: meson.project_source_root() / 'po', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Use join_paths
for consistency.
Consider using join_paths
for constructing paths to maintain consistency with the rest of the codebase. This can also help avoid potential issues with different path separators on different operating systems.
po_dir: meson.project_source_root() / 'po', | |
po_dir: join_paths(meson.project_source_root(), 'po'), |
install: true, | ||
install_dir: join_paths(get_option('datadir'), 'metainfo'), | ||
install_dir: get_option('datadir') / 'metainfo', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Use join_paths
for consistency.
Consider using join_paths
for constructing paths to maintain consistency with the rest of the codebase. This can also help avoid potential issues with different path separators on different operating systems.
install_dir: get_option('datadir') / 'metainfo', | |
install_dir: join_paths(get_option('datadir'), 'metainfo'), |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 51.90% 52.43% +0.52%
==========================================
Files 64 64
Lines 8375 8533 +158
==========================================
+ Hits 4347 4474 +127
- Misses 4028 4059 +31 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
This pull request improves the Meson build configuration by updating the required Meson version, adding summary sections for better visibility of configuration options and dependencies, and enhancing test definitions for better integration with the Google Test framework.