Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#625: add branch color #650

Merged
merged 1 commit into from
Jan 5, 2025
Merged

#625: add branch color #650

merged 1 commit into from
Jan 5, 2025

Conversation

lidaobing
Copy link
Member

@lidaobing lidaobing commented Jan 5, 2025

Summary by Sourcery

New Features:

  • Add a primary color to the application branding.

@lidaobing lidaobing linked an issue Jan 5, 2025 that may be closed by this pull request
Copy link

sourcery-ai bot commented Jan 5, 2025

Reviewer's Guide by Sourcery

This pull request adds a primary branch color branding to the application.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added primary color branding.
  • Added a new branding section to the metainfo file.
  • Set the primary color to #376ea5 for both light and dark scheme preferences.
share/metainfo/io.github.iptux_src.iptux.metainfo.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lidaobing - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using different colors for light and dark schemes to optimize visibility and user experience in each mode
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lidaobing lidaobing merged commit fc4ef0f into master Jan 5, 2025
12 of 13 checks passed
@lidaobing lidaobing deleted the 625-support-flatpak branch January 5, 2025 01:55
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.47%. Comparing base (c1c92d9) to head (ae233a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   52.47%   52.47%           
=======================================
  Files          64       64           
  Lines        8557     8557           
=======================================
  Hits         4490     4490           
  Misses       4067     4067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support flatpak
1 participant