Add optional sign_extensions field to [[chain]] config
#882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new field to the `ChainConfig` structure which represents an entry in the `[[chain]]` registry in tmkms.toml which indicates whether or not vote extensions should be signed. In the future we should be able to query this using the `signExtension` field of `SignVote`. See cometbft/cometbft#2439. However, for now this requires a manual configuration flag.
Shella
approved these changes
Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new field to the
ChainConfigstructure which represents an entry in the[[chain]]registry in tmkms.toml which indicates whether or not vote extensions should be signed.In the future we should be able to query this using the
signExtensionfield ofSignVote. See cometbft/cometbft#2439.However, for now this requires a manual configuration flag.