Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR-2274] Landing Page: Simplify the components configuration #176

Merged
merged 3 commits into from
May 24, 2024

Conversation

heysokam
Copy link
Contributor

@heysokam heysokam commented May 23, 2024

Description and checklist @IR-2274

@heysokam heysokam added documentation Improvements or additions to documentation general Anything related to the General/Overview section of the documentation website labels May 23, 2024
@heysokam heysokam requested a review from armando-salazar May 23, 2024 19:32
@heysokam heysokam self-assigned this May 23, 2024
heysokam added 2 commits May 23, 2024 21:36
fmt: Remove the `Simple*` version of the Landing Page components
fmt: Optional `renderAll` property drilled to each component to override the `render` properties of each
fmt: The `index.tsx` Landing Page does not define `renderAll` so it renders normally
fmt: The `landing.tsx` page is a copy of `index.tsx` that defines `renderAll` to keep its functionality
fmt: Remove the `LandingPageData` object from `landing.tsx`. Data moved to `website.config.ts`
bld: Previous commit also added `website.config.ts` to the `tailwindCSS` processor
@heysokam heysokam requested a review from DanielBelmes May 23, 2024 19:43
@heysokam heysokam marked this pull request as ready for review May 23, 2024 19:45
@armando-salazar armando-salazar merged commit b2768f2 into main May 24, 2024
2 of 3 checks passed
@armando-salazar armando-salazar deleted the IR-2274-simple-landing-page-persona-selection branch May 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation general Anything related to the General/Overview section of the documentation website verified-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants