Skip to content

Commit

Permalink
Merge pull request #4 from irfansofyana/fix/kafka-go-toolkit
Browse files Browse the repository at this point in the history
fix: kafka startup error
  • Loading branch information
irfansofyana authored Jan 4, 2025
2 parents 80de522 + eacd22a commit eda3dff
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
12 changes: 10 additions & 2 deletions src/go-toolkit/.devcontainer/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ services:
SERVER_SERVLET_CONTEXTPATH: "/"
depends_on:
- kafka
restart: unless-stopped
networks:
- app-network

Expand All @@ -108,6 +109,7 @@ services:
volumes:
- zookeeper-data:/var/lib/zookeeper/data
- zookeeper-logs:/var/lib/zookeeper/log
restart: unless-stopped
networks:
- app-network

Expand All @@ -125,6 +127,13 @@ services:
KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT
KAFKA_INTER_BROKER_LISTENER_NAME: PLAINTEXT
KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
healthcheck:
test: ["CMD", "kafka-topics", "--bootstrap-server", "kafka:29092", "--list"]
interval: 30s
timeout: 10s
retries: 3
start_period: 30s
restart: unless-stopped
volumes:
- kafka-data:/var/lib/kafka/data
networks:
Expand Down Expand Up @@ -153,5 +162,4 @@ volumes:
redis-data:
kafka-data:
zookeeper-data:
zookeeper-logs:
localstack-data:
zookeeper-logs:
2 changes: 1 addition & 1 deletion src/go-toolkit/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "go-toolkit",
"version": "1.0.2",
"version": "1.0.3",
"name": "Go Development Toolkit",
"description": "This is a devcontainer template for some of the typical stacks used in Go development such as MySQL, Redis, Kafka, etc.",
"documentationURL": "https://github.com/irfansofyana/devcontainer-templates/tree/main/src/go-toolkit",
Expand Down

0 comments on commit eda3dff

Please sign in to comment.