Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#275] Test hook: Remove unnecessary unittest-xml-reporting installation (4-3-stable) #276

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

alanking
Copy link
Contributor

@alanking alanking commented Aug 6, 2024

Addresses #275

Tests are still running, but this problem isn't happening anymore, so that's good.

…allation

We do not need to install this old version of unittest-xml-reporting.
The testing environment installs unittest-xml-reporting and the version
being installed there does not cause problems in newer versions of
python (3.11+) like this old version does.
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me.

Will wait for the results before approving.

@alanking
Copy link
Contributor Author

alanking commented Aug 6, 2024

Tests passed

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@alanking
Copy link
Contributor Author

alanking commented Aug 6, 2024

#'d. Mergin.

@alanking alanking merged commit 822347c into irods:4-3-stable Aug 6, 2024
1 check passed
@alanking alanking deleted the 275.43s branch August 6, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants