Fix tiering with complex permissions and rodsusers running tiering rules (main) #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korydraughn
reviewed
Jan 15, 2025
Restore use of tabs before running clang-format on all the code. AlignTrailingComments is false in irods/irods and is generally annoying, so don't restore that.
Also adds ability to specify a session for running the tiering rule in tests. Previously, this was done using a temporary session for an existing admin user.
This commit makes a couple of changes: 1. Added proxy_connection::make_rodsadmin_connection. This function simply establishes a client connection as the local service account rodsadmin. Importantly, it also sets the authFlag in the created RcComm in order to appropriately indicate the privilege level of the client user. 2. All instances of establishing a connection with the local server to perform actions have been replaced with connections as the local service account rodsadmin. This allows storage tiering to do its job properly without needing to worry about user permissions. Note: Violating queries still select the USER_NAME and USER_ZONE, but they are no longer used.
The lambda function fed to the irods::query_processor for scheduling violating data objects for migration had a race condition wherein objects marked as already having been processed were not protected by a mutex. This resulted in data objects with multiple users or groups with permissions on those data objects being scheduled for migration multiple times.
|
#'d, mergin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #164
Addresses #189
Addresses #273
Addresses #293
Cherry-picked from #295