[#57] Added support for hard links. #113
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korydraughn
commented
Jan 14, 2021
| Map<String, String> jsonInput = new HashMap<>(); | ||
| jsonInput.put("operation", "hard_link_create"); | ||
| jsonInput.put("logical_path", linkTargetPath.toString()); | ||
| jsonInput.put("replica_number", "0"); |
There was a problem hiding this comment.
How do we want to handle cases where replica zero does not exist?
There was a problem hiding this comment.
This could be controlled via the following:
- configuration
- metadata
- genquery that selects a specific replica based on certain criteria provided by the admin
There was a problem hiding this comment.
i don't know how we could safely assume anything... doesn't it have to come from the catalog?
There was a problem hiding this comment.
Maybe it executes genquery to find the latest good replica and it creates the hard link to that?
There was a problem hiding this comment.
I think latest good replica is the answer... trying to figure out how to get that information without another trip to the catalog...
|
I'd like to get w you all and test this to make sure the core libs support
correctly
…On Thu, Jan 21, 2021, 7:05 PM Kory Draughn ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
irods-vfs-impl/src/main/java/org/irods/nfsrods/vfs/IRODSVirtualFileSystem.java
<#113 (comment)>
:
> +
+ Path linkParentPath = getPath(toInodeNumber(_parent));
+ Path linkTargetPath = getPath(toInodeNumber(_existing));
+ Path linkNamePath = linkParentPath.resolve(_target);
+
+ log_.debug("list - _parent = {}", linkParentPath); // The parent directory of _target.
+ log_.debug("list - _existing = {}", linkTargetPath); // The file or directory to link to.
+ log_.debug("list - _target = {}", _target); // The filename or absolute path of the link.
+ log_.debug("list - _subject = {}", Subjects.getUid(_subject)); // The UID of the user who executed this command.
+
+ // _parent + _target => the absolute path of the hard link.
+
+ Map<String, String> jsonInput = new HashMap<>();
+ jsonInput.put("operation", "hard_link_create");
+ jsonInput.put("logical_path", linkTargetPath.toString());
+ jsonInput.put("replica_number", "0");
Maybe it executes genquery to find the latest good replica and it creates
the hard link to that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIL4LOV2X65UNZW3AUA65LS3C6LVANCNFSM4WDCRJXA>
.
|
|
Sure. Let me know when you'd like to do this. |
trel
reviewed
Feb 4, 2021
Comment on lines
+854
to
+857
| log_.debug("list - _parent = {}", linkParentPath); // The parent directory of _target. | ||
| log_.debug("list - _existing = {}", linkTargetPath); // The file or directory to link to. | ||
| log_.debug("list - _target = {}", _target); // The filename or absolute path of the link. | ||
| log_.debug("list - _subject = {}", Subjects.getUid(_subject)); // The UID of the user who executed this command. |
| @@ -1299,7 +1370,7 @@ private Stat statPath(Path _path, long _inodeNumber) throws IOException | |||
|
|
|||
| stat.setUid(userId); | |||
| stat.setGid(groupId); | |||
| stat.setNlink(1); | |||
| stat.setNlink(1); // TODO: Should hard links affect this number? | |||
There was a problem hiding this comment.
we'd increase it and then... decrease it somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to include documentation about the hard links REP. This also needs to be tested against the version of WinSCP that triggered this change.