Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[irods/irods#7823] Migrate workflows to Ubuntu 24.04 #10

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[irods/irods#7823] Migrate workflows to Ubuntu 24.04 #10

merged 1 commit into from
Dec 16, 2024

Conversation

SwooshyCueb
Copy link
Member

In service of irods/irods#7823

Also adds [.h,.c.,.hpp,.cpp].in files to clang-format extension list

Draft because waiting on externals packages, and still testing

@SwooshyCueb SwooshyCueb force-pushed the 7823.main branch 2 times, most recently from b7eb567 to 0f61773 Compare December 11, 2024 22:51
@SwooshyCueb SwooshyCueb marked this pull request as ready for review December 11, 2024 22:52
@SwooshyCueb
Copy link
Member Author

I've tested the changes in a container, and everything seems to work. Marking ready for review.

@korydraughn
Copy link
Collaborator

I've tested the changes in a container, and everything seems to work. Marking ready for review.

How does this PR relate to your comment at irods/irods#8079 (comment)? Is this resolved?

I noticed sudo is still in use, which aligns with the comment I referenced.

@SwooshyCueb
Copy link
Member Author

How does this PR relate to your comment at irods/irods#8079 (comment)? Is this resolved?

I was originally going to try and knock that issue out in this PR, but decided against it since I need to look into it more.

@korydraughn
Copy link
Collaborator

Got it.

The clang-format edit removes sudo. Should that be reverted for now?

@SwooshyCueb
Copy link
Member Author

yes, nice catch

korydraughn
korydraughn reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Anything else left to do for this?

@SwooshyCueb
Copy link
Member Author

Nope, as far as I can tell it works as expected. I can't test in the same environment github uses, but everything works as expected in a container.

@alanking
Copy link

I didn't see any mention of it in the issue or elsewhere so I guess I'll ask here... The libcxx and non-libcxx variants of the externals are being included so that we can use either in our clang-tidy runs?

@SwooshyCueb
Copy link
Member Author

That's correct. There weren't separate versions yet last time this was updated.

alanking
alanking approved these changes Dec 16, 2024
View reviewed changes
Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# it

@SwooshyCueb
[irods/irods#7823] Migrate workflows to Ubuntu 24.04
08410e5 
Also, add .in files to clang-format extension list
@SwooshyCueb
Copy link
Member Author

#'d

@alanking alanking merged commit b95c8cd into irods:main Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn approved these changes

@alanking alanking alanking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwooshyCueb @korydraughn @alanking