Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irods/irods#7286] Use system libarchive #11

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

SwooshyCueb
Copy link
Member

In service of irods/irods#7286

Copy link
Collaborator

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Is this blocked by any of the other PRs?

@SwooshyCueb
Copy link
Member Author

I don't think so

@korydraughn
Copy link
Collaborator

If we merge this, github actions for PRs that are dependent on the libarchive externals pkg will start to fail for 4-3-stable, correct?

@alanking
Copy link

alanking commented Feb 3, 2025

If we merge this, github actions for PRs that are dependent on the libarchive externals pkg will start to fail for 4-3-stable, correct?

Looks like 4-3-stable will be healed once irods/irods#8156 is merged.

@SwooshyCueb
Copy link
Member Author

If we merge this, github actions for PRs that are dependent on the libarchive externals pkg will start to fail for 4-3-stable, correct?

Looks like 4-3-stable will be healed once irods/irods#8156 is merged.

To my understanding, the irods repo has its own worflows and does not use the ones from this repo. Additionally, none of our other projects (aside from mungefs, which also doesn't use these workflows to my knowledge) use libarchive AFAIK.

@korydraughn
Copy link
Collaborator

That sounds correct to me.

I say let's get this merged.

Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's # it

@SwooshyCueb
Copy link
Member Author

#'d

@alanking alanking merged commit 5368f11 into irods:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants