-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[irods/irods#7286] Use system libarchive #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Is this blocked by any of the other PRs?
I don't think so |
If we merge this, github actions for PRs that are dependent on the libarchive externals pkg will start to fail for 4-3-stable, correct? |
Looks like 4-3-stable will be healed once irods/irods#8156 is merged. |
To my understanding, the irods repo has its own worflows and does not use the ones from this repo. Additionally, none of our other projects (aside from mungefs, which also doesn't use these workflows to my knowledge) use libarchive AFAIK. |
That sounds correct to me. I say let's get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's # it
0b95ae0
to
f2a5b46
Compare
#'d |
In service of irods/irods#7286