Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: identity and authentication #52

Open
wants to merge 48 commits into
base: release-3
Choose a base branch
from
Open

refactor: identity and authentication #52

wants to merge 48 commits into from

Conversation

lipa44
Copy link
Member

@lipa44 lipa44 commented Jun 23, 2022 •
edited
Loading

Вкратце опиши свои изменения

  1. Я добавил аттрибуты авторизации на контроллеры
  2. Я настроил авторизацию/аутентификацию в сваггере и добавил возможность авторизоваться используя Swagger UI
  3. Добавил эндпоинт аутентификации юзера по Jwt токену для сторонних сервисов
  4. Немного пересмотрел структуру авторизации/аутентификации
  5. Подумал о том, зачем нам нужны MessengerUser && IdentityUser - и решил смержить эти сущности, теперь у нас только один юзер, у которого есть базовая информация: юзерНейм, логин и тд, и есть ChatUser (который был и до этого), на котором уже лежит логика взаимодействия с чатами

Номер выполненной ишуи

@lipa44 lipa44 added api Base api functionality for controllers integration Integration stuff labels Jun 23, 2022
@lipa44 lipa44 added this to the Sprint 2 milestone Jun 23, 2022
@lipa44 lipa44 self-assigned this Jun 23, 2022
@lipa44 lipa44 linked an issue Jun 23, 2022 that may be closed by this pull request
Make authentication && authorization great again #53
Open
3 tasks
This was linked to issues Jun 25, 2022
Implement error-handling middleware #16
Open
Add error-codes realization and support in controllers and CQRS #38
Open
Mikhail Libchenko added 3 commits June 25, 2022 15:50
Merge remote-tracking branch 'origin/release-3' into refactor/identit…
4fcaf80 
…y-and-authentication

# Conflicts:
#	Source/Application/Do-Svyazi.User.Application/CQRS/Chats/Handlers/ChatsCommandHandler.cs
#	Source/Application/Do-Svyazi.User.Application/CQRS/Users/Handlers/UsersQueryHandler.cs
#	Source/Domain/Do-Svyazi.User.Domain/Users/MessengerUser.cs
#	Source/Infrastructure/Do-Svyazi.User.Web.Api/Startup.cs
#	Source/Tests/CQRS.Tests/ChatTests.cs
refactor!: MessageIdentityUser merged with MessengerUser
652191e
fix: tests updated after refactor
cec0032
@lipa44 lipa44 marked this pull request as ready for review June 25, 2022 23:41
@lipa44 lipa44 requested a review from KotDimos June 25, 2022 23:41
@lipa44
Copy link
Member Author

lipa44 commented Jun 25, 2022

@KotDimos чекни пж что ничего не сломалось

я протестил, тестики подправил - всё вроде работает, но мб что-то пропустил

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KotDimos KotDimos KotDimos approved these changes

Assignees

@lipa44 lipa44

Labels
api Base api functionality for controllers integration Integration stuff
Projects
None yet
Milestone
Sprint 2
2 participants
@lipa44 @KotDimos