Update Ada nav items #1022
Merged
Update Ada nav items #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why this has started failing, but I'm satisfied it's not a real issue caused by these changes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/test/pages/MyAccount.test.tsx
Outdated
| @@ -4,7 +4,7 @@ | |||
| mockActiveGroups, | |||
| buildMockTeacher, | |||
| buildMockUserSummary} from "../../mocks/data"; | |||
| import { followHeaderNavLink, renderTestEnvironment, switchAccountTab } from "../testUtils"; | |||
| import {followHeaderNavLink, navigateToMyAccount, renderTestEnvironment, switchAccountTab} from "../testUtils"; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note test
src/test/pages/Groups.test.tsx
Outdated
| @@ -10,7 +15,7 @@ | |||
| buildMockStudent, | |||
| buildMockUserSummaryWithGroupMembership | |||
| } from "../../mocks/data"; | |||
| import {ACCOUNT_TAB, API_PATH, extractTeacherName, isDefined, siteSpecific} from "../../app/services"; | |||
| import {ACCOUNT_TAB, API_PATH, extractTeacherName, isDefined, isPhy, siteSpecific} from "../../app/services"; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
- Coverage 37.17% 37.15% -0.03%
==========================================
Files 420 420
Lines 18486 18516 +30
Branches 6033 6066 +33
==========================================
+ Hits 6873 6879 +6
+ Misses 11574 11018 -556
- Partials 39 619 +580 ☔ View full report in Codecov by Sentry. |
mlt47
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Ada navbar items to match designs (see Trello card). This required some test changes as menu items no longer map directly to one another across sites.