Require due date when setting assignments and tests #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Assignment Schedule didn't seem to disable the button on an invalid due date or show the warning, so this fixes the logic in Set Assignments and copies it over too. Quizzes have a slightly different check to assignments because the deadlines work differently, but this may no longer be necessary in the future.
This does nothing to check that the due date is correct or meaningful, just that it is possible to select one.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
+ Coverage 36.48% 36.67% +0.18%
==========================================
Files 456 456
Lines 19855 19855
Branches 5856 6508 +652
==========================================
+ Hits 7245 7282 +37
+ Misses 12572 12535 -37
Partials 38 38 ☔ View full report in Codecov by Sentry. |
axlewin
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Assignment Schedule didn't seem to disable the button on an invalid due date or show the warning, so this fixes the logic in Set Assignments and copies it over too.
Quizzes have a slightly different check to assignments because the deadlines work differently, but this may no longer be necessary in the future.