Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fixes and small adjustments #34

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Conversation

vicenterusso
Copy link
Member

No description provided.

@vicenterusso vicenterusso requested review from mdmm13 and mrclauss March 23, 2024 03:55
@@ -14,10 +14,12 @@ environment:

dependencies:
ffi: ">=2.0.0 <3.0.0"
isar_test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this extra dependency (for everybody using Isar)?

isar:
version: 3.1.4
hosted: https://isar-community.dev/
isar:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring local paths won't work for everybody else

Copy link
Member

@mrclauss mrclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring to local paths in pubspec works for your (or the github action) setup, but not for the end user...

@vicenterusso
Copy link
Member Author

Do you have a use case where this will not work for end users?

@mrclauss
Copy link
Member

mrclauss commented Mar 23, 2024

Do you have a use case where this will not work for end users?

Uhm for everyone :)
I'm pretty sure you cannot publish a package to pub.dev or our package repo that refers to local paths in its dependencies...
This will only work if you have the isar sources checked out locally (which the regular user won't want)

@vicenterusso
Copy link
Member Author

Do you have a use case where this will not work for end users?

Uhm for everyone :) I'm pretty sure you cannot publish a package to pub.dev or our package repo that refers to local paths in its dependencies... This will only work if you have the isar sources checked out locally (which the regular user won't want)

Should be an easy change after publishing then

@richard457
Copy link

we might need to consider https://melos.invertase.dev/ for local packages this can help when it is time to publish as well to pub.dev

@mrclauss
Copy link
Member

Looks good to me

@vicenterusso vicenterusso merged commit d10191a into v3 Mar 27, 2024
17 checks passed
@vicenterusso vicenterusso deleted the v3-fix-all-tests-passed branch March 27, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants