Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating v4 workflow and tests #40

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Updating v4 workflow and tests #40

merged 2 commits into from
Apr 1, 2024

Conversation

vicenterusso
Copy link
Member

No description provided.

@vicenterusso vicenterusso requested review from mdmm13 and mrclauss March 30, 2024 03:42
Copy link
Member

@mrclauss mrclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if you can remove my workaround in the windows build script...

if: runner.os == 'Windows'
shell: bash
run: |
choco install make
- name: Set Windows environment variables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might try removing this commit from me:
9f7eced

I suspect the clang installer broke the windows build before...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might try removing this commit from me: 9f7eced

I suspect the clang installer broke the windows build before...

(That would fix #22 )

@vicenterusso vicenterusso requested a review from mrclauss March 30, 2024 16:21
@vicenterusso vicenterusso merged commit 3fb3795 into main Apr 1, 2024
17 checks passed
@vicenterusso vicenterusso deleted the updating-tests-v4 branch April 1, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants