Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/docs versioning v3 #77

Merged
merged 2 commits into from
May 7, 2024
Merged

Bugfix/docs versioning v3 #77

merged 2 commits into from
May 7, 2024

Conversation

mrclauss
Copy link
Member

@mrclauss mrclauss commented May 6, 2024

No description provided.

@mrclauss mrclauss requested a review from vicenterusso May 6, 2024 17:08
@vicenterusso
Copy link
Member

Simon made the replacement directly inside the release.yaml. Do you think we can still use it?

     - name: Set Isar Version
        run: echo "ISAR_VERSION=${{ github.ref_name }}" >> $GITHUB_ENV
      - name: Download Binaries
        run: sh tool/download_binaries.sh
      - name: Adjust Version
        run: find . -type f -exec sed -i "s/0.0.0-placeholder/${{ github.ref_name }}/g" {} +

@mrclauss
Copy link
Member Author

mrclauss commented May 7, 2024

As long as we publish to the hosted solution we need this, because I don't run the release.yaml locally when building the dart packages. And we need the same replacement in every doc build. So having this in a separate script would be good

@mrclauss mrclauss merged commit 523c152 into v3 May 7, 2024
16 of 17 checks passed
@mrclauss mrclauss deleted the bugfix/docs-versioning-v3 branch May 7, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants